Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change RoIImage and MosaicImage to have np.uint8 dtype as default #1245

Conversation

vinnamkim
Copy link
Contributor

Summary

How to test

I believe the existing tests (tests/unit/test_images.py) can cover it.

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim marked this pull request as ready for review January 19, 2024 08:16
@vinnamkim vinnamkim requested review from a team as code owners January 19, 2024 08:16
@vinnamkim vinnamkim requested review from jihyeonyi and removed request for a team January 19, 2024 08:16
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f0d7b13) 80.53% compared to head (7a3a4f1) 80.53%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1245   +/-   ##
========================================
  Coverage    80.53%   80.53%           
========================================
  Files          270      270           
  Lines        30243    30241    -2     
  Branches      5905     5904    -1     
========================================
- Hits         24356    24355    -1     
  Misses        4506     4506           
+ Partials      1381     1380    -1     
Flag Coverage Δ
ubuntu-20.04_Python-3.8 80.51% <100.00%> (+<0.01%) ⬆️
windows-2022_Python-3.8 80.50% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vinnamkim vinnamkim merged commit a905a0c into openvinotoolkit:develop Jan 23, 2024
6 checks passed
@vinnamkim vinnamkim deleted the fix/change-roi-iamge-and-mosaic-image-dtype-to-uint8 branch January 23, 2024 00:43
@yunchu yunchu added this to the 2.0.0 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants