Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicated label import for Kaggle importer #1244

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

wonjuleee
Copy link
Contributor

@wonjuleee wonjuleee commented Jan 15, 2024

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@wonjuleee wonjuleee requested review from a team as code owners January 15, 2024 06:32
@wonjuleee wonjuleee requested review from vinnamkim and removed request for a team January 15, 2024 06:32
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5f8ddef) 80.53% compared to head (15f8dee) 80.50%.

❗ Current head 15f8dee differs from pull request most recent head aa0c396. Consider uploading reports for the commit aa0c396 to get more accurate results

Files Patch % Lines
src/datumaro/plugins/data_formats/kaggle/base.py 81.81% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1244      +/-   ##
===========================================
- Coverage    80.53%   80.50%   -0.04%     
===========================================
  Files          270      269       -1     
  Lines        30238    30214      -24     
  Branches      5903     5900       -3     
===========================================
- Hits         24353    24323      -30     
- Misses        4506     4509       +3     
- Partials      1379     1382       +3     
Flag Coverage Δ
ubuntu-20.04_Python-3.8 ?
windows-2022_Python-3.8 80.50% <81.81%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wonjuleee wonjuleee merged commit f0d7b13 into openvinotoolkit:develop Jan 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants