Add memory bounded datumaro data format detect to release 1.5.1 #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ticket no. 127135 and 127136.
- Develop `JsonSectionPageMapper` to construct page maps for top-level
sections in a given JSON file.
- Enhance `DatumaroImporter.detect()`'s performance by replacing JSON
file parsing logic with the `JsonSectionPageMapper`.
Our existing test will validate its functionality. For the performance
comparison, please see the following.
- Before
```python
from datumaro.rust_api import JsonSectionPageMapper
from time import time
import datumaro as dm
start = time()
format = dm.Dataset.detect("ws_test/coco/datumaro")
dt = 1000.0 * (time() - start)
print(f"Duration for detecting Datumaro data format: {dt:.1f}ms, format={format}")
```
```console
Duration for detecting Datumaro data format: 25784.5ms, format=datumaro
```
- After
```python
from datumaro.rust_api import JsonSectionPageMapper
from time import time
import datumaro as dm
start = time()
format = dm.Dataset.detect("ws_test/coco/datumaro")
dt = 1000.0 * (time() - start)
print(f"Duration for detecting Datumaro data format: {dt:.1f}ms, format={format}")
```
```console
Duration for detecting Datumaro data format: 17234.7ms, format=datumaro
```
It saves ~7 secs.
<!-- Put an 'x' in all the boxes that apply -->
- [ ] I have added unit tests to cover my changes.
- [ ] I have added integration tests to cover my changes.
- [x] I have added the description of my changes into
[CHANGELOG](https://github.com/openvinotoolkit/datumaro/blob/develop/CHANGELOG.md).
- [ ] I have updated the
[documentation](https://github.com/openvinotoolkit/datumaro/tree/develop/docs)
accordingly
- [x] I submit _my code changes_ under the same [MIT
License](https://github.com/openvinotoolkit/datumaro/blob/develop/LICENSE)
that covers the project.
Feel free to contact the maintainers if that's a concern.
- [x] I have updated the license header for each file (see an example
below).
```python
```
---------
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
…mant (openvinotoolkit#1229) - Ticket no. 127136 Refer to openvinotoolkit#1224 for details on how we obtained the following results. 1. Performance - Before ```console Duration for detecting Datumaro data format: 25784.5ms, format=datumaro ``` - After ```console Duration for detecting Datumaro data format: 5966.8ms, format=datumaro ``` 2. Memory usage - Before  - After  <!-- Put an 'x' in all the boxes that apply --> - [ ] I have added unit tests to cover my changes. - [ ] I have added integration tests to cover my changes. - [x] I have added the description of my changes into [CHANGELOG](https://github.com/openvinotoolkit/datumaro/blob/develop/CHANGELOG.md). - [ ] I have updated the [documentation](https://github.com/openvinotoolkit/datumaro/tree/develop/docs) accordingly - [x] I submit _my code changes_ under the same [MIT License](https://github.com/openvinotoolkit/datumaro/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern. - [x] I have updated the license header for each file (see an example below). ```python ``` --------- Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## releases/1.5.0 #1241 +/- ##
===============================================
Coverage 79.97% 79.97%
===============================================
Files 265 265
Lines 29705 29732 +27
Branches 5831 5833 +2
===============================================
+ Hits 23756 23778 +22
- Misses 4617 4619 +2
- Partials 1332 1335 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wonjuleee
approved these changes
Jan 10, 2024
vinnamkim
merged commit e426036
into
openvinotoolkit:releases/1.5.0
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How to test
Already tested in the previous PRs.
Checklist
License
Feel free to contact the maintainers if that's a concern.