Enhance Datumaro data format detect() to be memory-bounded and performant #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1229 +/- ##
========================================
Coverage 80.44% 80.45%
========================================
Files 269 269
Lines 29919 29944 +25
Branches 5851 5853 +2
========================================
+ Hits 24069 24090 +21
- Misses 4487 4488 +1
- Partials 1363 1366 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vinnamkim
added a commit
to vinnamkim/datumaro
that referenced
this pull request
Jan 9, 2024
…mant (openvinotoolkit#1229) - Ticket no. 127136 Refer to openvinotoolkit#1224 for details on how we obtained the following results. 1. Performance - Before ```console Duration for detecting Datumaro data format: 25784.5ms, format=datumaro ``` - After ```console Duration for detecting Datumaro data format: 5966.8ms, format=datumaro ``` 2. Memory usage - Before  - After  <!-- Put an 'x' in all the boxes that apply --> - [ ] I have added unit tests to cover my changes. - [ ] I have added integration tests to cover my changes. - [x] I have added the description of my changes into [CHANGELOG](https://github.com/openvinotoolkit/datumaro/blob/develop/CHANGELOG.md). - [ ] I have updated the [documentation](https://github.com/openvinotoolkit/datumaro/tree/develop/docs) accordingly - [x] I submit _my code changes_ under the same [MIT License](https://github.com/openvinotoolkit/datumaro/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern. - [x] I have updated the license header for each file (see an example below). ```python ``` --------- Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
6 tasks
vinnamkim
added a commit
that referenced
this pull request
Jan 11, 2024
### Summary - Ticket no 128951 - Apply #1224 and #1229 changes to the releases/1.5.0 branch ### How to test Already tested in the previous PRs. ### Checklist <!-- Put an 'x' in all the boxes that apply --> - [ ] I have added unit tests to cover my changes. - [ ] I have added integration tests to cover my changes. - [ ] I have added the description of my changes into [CHANGELOG](https://github.com/openvinotoolkit/datumaro/blob/develop/CHANGELOG.md). - [ ] I have updated the [documentation](https://github.com/openvinotoolkit/datumaro/tree/develop/docs) accordingly ### License - [ ] I submit _my code changes_ under the same [MIT License](https://github.com/openvinotoolkit/datumaro/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern. - [ ] I have updated the license header for each file (see an example below). ```python # Copyright (C) 2023 Intel Corporation # # SPDX-License-Identifier: MIT ``` --------- Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How to test
Refer to #1224 for details on how we obtained the following results.
Duration for detecting Datumaro data format: 25784.5ms, format=datumaroDuration for detecting Datumaro data format: 5966.8ms, format=datumaroChecklist
License
Feel free to contact the maintainers if that's a concern.