Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct datum project import examples #1210

Conversation

jihyeonyi
Copy link
Contributor

@jihyeonyi jihyeonyi commented Nov 28, 2023

Summary

  1. Correct documents to use correctly use 'datum project import' command.
  2. Add filtering example to filter out items containing annotations only. (Filter out items without annotations #1208)

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@jihyeonyi jihyeonyi requested review from a team as code owners November 28, 2023 03:15
@jihyeonyi jihyeonyi requested review from vinnamkim and removed request for a team November 28, 2023 03:15
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (231f6d9) 80.07% compared to head (1b54b1d) 80.08%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1210   +/-   ##
========================================
  Coverage    80.07%   80.08%           
========================================
  Files          268      268           
  Lines        29865    29865           
  Branches      5846     5846           
========================================
+ Hits         23915    23916    +1     
  Misses        4617     4617           
+ Partials      1333     1332    -1     
Flag Coverage Δ
macos-11_Python-3.8 79.19% <ø> (ø)
ubuntu-20.04_Python-3.8 80.07% <ø> (+<0.01%) ⬆️
windows-2022_Python-3.8 80.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jihyeonyi jihyeonyi merged commit 27e3804 into openvinotoolkit:develop Nov 28, 2023
6 checks passed
@jihyeonyi jihyeonyi deleted the jihyeony/update-doc-datum-project-import branch November 28, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants