Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix label compare of distance method #1205

Merged
merged 7 commits into from
Nov 28, 2023

Conversation

sooahleex
Copy link
Contributor

@sooahleex sooahleex commented Nov 27, 2023

Summary

  • Fix label comparison result of distance method
  • Example: dataset1 included label ['a', 'b] and dataset2 included label ['background', 'a', 'b', 'c']
    • Expected Result :
      < c
      < background
    • Actual Result:
      a != background
      b != a
      < b
      < c
  • Ticket no. 124879

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@sooahleex sooahleex marked this pull request as ready for review November 27, 2023 09:16
@sooahleex sooahleex requested review from a team as code owners November 27, 2023 09:16
@sooahleex sooahleex requested review from jihyeonyi and removed request for a team November 27, 2023 09:16
@sooahleex sooahleex added the BUG Something isn't working label Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (27e3804) 80.07% compared to head (3547784) 80.08%.

❗ Current head 3547784 differs from pull request most recent head 2ae3c13. Consider uploading reports for the commit 2ae3c13 to get more accurate results

Files Patch % Lines
src/datumaro/cli/util/compare.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1205   +/-   ##
========================================
  Coverage    80.07%   80.08%           
========================================
  Files          268      268           
  Lines        29865    29863    -2     
  Branches      5846     5845    -1     
========================================
+ Hits         23915    23916    +1     
+ Misses        4617     4614    -3     
  Partials      1333     1333           
Flag Coverage Δ
macos-11_Python-3.8 79.20% <22.22%> (+<0.01%) ⬆️
ubuntu-20.04_Python-3.8 80.07% <22.22%> (+<0.01%) ⬆️
windows-2022_Python-3.8 80.05% <22.22%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sooahleex sooahleex force-pushed the bugfix/dist_compare branch 2 times, most recently from 887f824 to 9759aec Compare November 28, 2023 06:10
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sooahleex sooahleex merged commit 4b9f55f into openvinotoolkit:develop Nov 28, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants