Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning instead of raising an error for unsupported annotation types #1180

Conversation

jihyeonyi
Copy link
Contributor

@jihyeonyi jihyeonyi commented Oct 23, 2023

Summary

Modify the draw function in the visualizer to prevent it from raising an error for unsupported annotation types.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@jihyeonyi jihyeonyi marked this pull request as ready for review October 23, 2023 04:33
@jihyeonyi jihyeonyi requested review from a team as code owners October 23, 2023 04:33
@jihyeonyi jihyeonyi requested review from wonjuleee and removed request for a team October 23, 2023 04:33
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (releases/1.5.0@c2a31a8). Click here to learn what that means.

❗ Current head 10a348b differs from pull request most recent head d7731a8. Consider uploading reports for the commit d7731a8 to get more accurate results

Additional details and impacted files
@@                Coverage Diff                @@
##             releases/1.5.0    #1180   +/-   ##
=================================================
  Coverage                  ?   79.97%           
=================================================
  Files                     ?      265           
  Lines                     ?    29703           
  Branches                  ?     5831           
=================================================
  Hits                      ?    23754           
  Misses                    ?     4617           
  Partials                  ?     1332           
Flag Coverage Δ
ubuntu-20.04_Python-3.8 79.97% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jihyeonyi jihyeonyi merged commit 7803691 into openvinotoolkit:releases/1.5.0 Oct 23, 2023
4 checks passed
@jihyeonyi jihyeonyi deleted the jihyeony/visualizer-warning-for-unsupported-anntype branch October 23, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants