Fix Roboflow format: Disable roboflow_tfrecord when tf is not installed #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonjuleee
requested review from
jihyeonyi and
sooahleex
and removed request for
a team
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1130 +/- ##
===========================================
+ Coverage 80.08% 80.16% +0.08%
===========================================
Files 259 260 +1
Lines 29338 29370 +32
Branches 5751 5757 +6
===========================================
+ Hits 23495 23545 +50
+ Misses 4498 4484 -14
+ Partials 1345 1341 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
vinnamkim
reviewed
Aug 28, 2023
wonjuleee
force-pushed
the
fix_roboflow
branch
from
0543635
to
b397886
Compare
vinnamkim
reviewed
Aug 28, 2023
| path=path, ext=".tfrecord", extractor_name="roboflow_tfrecord", filename="cells" | ||
| path=path, | ||
| ext=".tfrecord", | ||
| extractor_name="", |
There was a problem hiding this comment.
Is it ok to set extractor_name=""?
There was a problem hiding this comment.
Yes it was, but it would be better to specify the extractor_name again. I will fix this.
vinnamkim
reviewed
Aug 28, 2023
wonjuleee
force-pushed
the
fix_roboflow
branch
from
5d296c6
to
2f73dff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.