Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ClassificationValidator to cope with multilabel classification datasets with label_groups #1116

Merged
merged 9 commits into from
Aug 7, 2023

Conversation

wonjuleee
Copy link
Contributor

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@wonjuleee wonjuleee requested review from a team as code owners August 3, 2023 02:07
@wonjuleee wonjuleee requested review from sooahleex and removed request for a team August 3, 2023 02:07
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023

Codecov Report

Patch coverage: 94.11% and project coverage change: +0.01% 🎉

Comparison is base (993c9f0) 79.99% compared to head (cd7d573) 80.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1116      +/-   ##
===========================================
+ Coverage    79.99%   80.00%   +0.01%     
===========================================
  Files          258      258              
  Lines        29300    29329      +29     
  Branches      5740     5745       +5     
===========================================
+ Hits         23438    23465      +27     
- Misses        4514     4517       +3     
+ Partials      1348     1347       -1     
Flag Coverage Δ
macos-11_Python-3.8 79.10% <94.11%> (+0.02%) ⬆️
ubuntu-20.04_Python-3.8 ?
windows-2019_Python-3.8 79.91% <94.11%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/datumaro/plugins/data_formats/datumaro/base.py 88.03% <ø> (ø)
...datumaro/plugins/data_formats/datumaro/exporter.py 95.41% <ø> (ø)
src/datumaro/components/annotation.py 89.52% <84.61%> (-0.13%) ⬇️
src/datumaro/plugins/validators.py 94.96% <100.00%> (+0.14%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vinnamkim vinnamkim added the ENHANCE Enhancement of existing features label Aug 4, 2023
@vinnamkim vinnamkim added this to the 1.5.0 milestone Aug 4, 2023
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would you insert a new line at the end of files? You can enable this option in your VSCode to make it always on.

image

@wonjuleee
Copy link
Contributor Author

LGTM, but would you insert a new line at the end of files? You can enable this option in your VSCode to make it always on.

image

Thank you for letting me know this. I set up settings.json and added new lines in annotation files.

@wonjuleee wonjuleee merged commit c84a13d into openvinotoolkit:develop Aug 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENHANCE Enhancement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants