Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give notice that the deprecation works will be done in datumaro==1.5.0 #1085

Merged
merged 3 commits into from
Jul 10, 2023
Merged

Give notice that the deprecation works will be done in datumaro==1.5.0 #1085

merged 3 commits into from
Jul 10, 2023

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Jul 10, 2023 •
edited
Loading

Summary

  • Same as title
  • The deprecation works remaining in the project will be done until datumaro==1.5.0.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@vinnamkim vinnamkim added this to the 1.4.0 milestone Jul 10, 2023
@vinnamkim vinnamkim added the ENHANCE Enhancement of existing features label Jul 10, 2023
@vinnamkim
Give notice that the deprecation works will be done in datumaro==1.5.0
fa8e441 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim marked this pull request as ready for review July 10, 2023 02:30
@vinnamkim vinnamkim requested review from a team as code owners July 10, 2023 02:30
@vinnamkim
Update CHANGELOG.md
e42bcfa 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Fix error
60bdbda 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim merged commit fcd57b8 into openvinotoolkit:releases/1.4.0 Jul 10, 2023
4 checks passed
@vinnamkim vinnamkim deleted the hotfix/deprecation-notice branch July 10, 2023 05:08
@vinnamkim vinnamkim mentioned this pull request Sep 4, 2023
Merged
6 tasks
vinnamkim added a commit that referenced this pull request Sep 6, 2023
@vinnamkim
Remove deprecates announced to be removed in 1.5.0 (#1140)
4c7cc87 
- Remove deprecates announced to be removed in 1.5.0 (announced at 1.4.0
#1085)

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sooahleex sooahleex sooahleex approved these changes

@yunchu yunchu Awaiting requested review from yunchu yunchu is a code owner automatically assigned from openvinotoolkit/datumaro-admins

@chuneuny-emily chuneuny-emily Awaiting requested review from chuneuny-emily chuneuny-emily is a code owner automatically assigned from openvinotoolkit/datumaro-admins

@jihyeonyi jihyeonyi Awaiting requested review from jihyeonyi jihyeonyi is a code owner automatically assigned from openvinotoolkit/datumaro-admins

@wonjuleee wonjuleee Awaiting requested review from wonjuleee wonjuleee is a code owner automatically assigned from openvinotoolkit/datumaro-admins

Assignees
No one assigned
Labels
ENHANCE Enhancement of existing features
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vinnamkim @sooahleex