Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LabelMe data format #1053

Merged
merged 5 commits into from
Jun 21, 2023
Merged

Fix LabelMe data format #1053

merged 5 commits into from
Jun 21, 2023

Conversation

wonjuleee
Copy link
Contributor

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@wonjuleee wonjuleee added BUG Something isn't working data formats PR is related to dataset formats labels Jun 19, 2023
@wonjuleee wonjuleee requested review from a team as code owners June 19, 2023 03:04
vinnamkim
vinnamkim reviewed Jun 20, 2023
View reviewed changes
src/datumaro/plugins/data_formats/labelme.py Outdated
Comment on lines 369 to 370
# subset_dir = osp.join(self._save_dir, subset_name)
# os.makedirs(subset_dir, exist_ok=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# subset_dir = osp.join(self._save_dir, subset_name)
# os.makedirs(subset_dir, exist_ok=True)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed. Thanks.

vinnamkim
vinnamkim approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wonjuleee wonjuleee merged commit 6e25d74 into openvinotoolkit:develop Jun 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinnamkim vinnamkim vinnamkim approved these changes

@sooahleex sooahleex sooahleex approved these changes

@chuneuny-emily chuneuny-emily Awaiting requested review from chuneuny-emily chuneuny-emily is a code owner automatically assigned from openvinotoolkit/datumaro-admins

@sstrehlk sstrehlk Awaiting requested review from sstrehlk sstrehlk is a code owner automatically assigned from openvinotoolkit/datumaro-admins

@bonhunko bonhunko Awaiting requested review from bonhunko bonhunko is a code owner automatically assigned from openvinotoolkit/datumaro-admins

Assignees
No one assigned
Labels
BUG Something isn't working data formats PR is related to dataset formats
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wonjuleee @vinnamkim @sooahleex