Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jupyter notebook example of noisy label detection for detection tasks #1011

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented May 23, 2023

Summary

  • Ticket no. 103076
  • Add Jupyter notebook example of noisy label detection for detection tasks
  • Update Visualizer and LossDynamicsAnalyzer to support detection tasks.

How to test

I added relevant tests for this change.

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim marked this pull request as ready for review May 23, 2023 06:41
@vinnamkim vinnamkim requested review from a team as code owners May 23, 2023 06:41
@vinnamkim vinnamkim added this to the 1.3.0 milestone May 23, 2023
@vinnamkim vinnamkim added DOC Improvements or additions to documentation ENHANCE Enhancement of existing features labels May 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2023

Codecov Report

Patch coverage: 70.96% and project coverage change: -0.01 ⚠️

Comparison is base (7351ba2) 78.59% compared to head (54656fe) 78.58%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           releases/1.3.0    #1011      +/-   ##
==================================================
- Coverage           78.59%   78.58%   -0.01%     
==================================================
  Files                 237      237              
  Lines               27063    27074      +11     
  Branches             5397     5401       +4     
==================================================
+ Hits                21269    21275       +6     
- Misses               4530     4534       +4     
- Partials             1264     1265       +1     
Flag Coverage Δ
macos-11_Python-3.8 77.59% <70.96%> (-0.02%) ⬇️
ubuntu-20.04_Python-3.8 78.56% <70.96%> (-0.01%) ⬇️
windows-2019_Python-3.8 78.46% <70.96%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ms/noisy_label_detection/loss_dynamics_analyzer.py 84.94% <66.66%> (-3.56%) ⬇️
datumaro/components/visualizer.py 88.72% <75.00%> (-0.26%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@cih9088 cih9088 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LossDynamicAnalyzer seems like too much OTX dependent.
We might need refactoring in near future.

notebooks/13_noisy_label_detection_det.ipynb Outdated Show resolved Hide resolved
@vinnamkim vinnamkim force-pushed the enhance/add-noisy-label-det-example branch from 210f894 to f967f23 Compare May 23, 2023 08:47
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Copy link
Contributor

@bonhunko bonhunko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I left a minor suggestion.

@vinnamkim vinnamkim merged commit dbb72dd into openvinotoolkit:releases/1.3.0 May 24, 2023
@vinnamkim vinnamkim deleted the enhance/add-noisy-label-det-example branch May 24, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DOC Improvements or additions to documentation ENHANCE Enhancement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants