Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Segment Anything data format #1005

Merged
merged 16 commits into from
May 22, 2023

Conversation

cih9088
Copy link
Contributor

@cih9088 cih9088 commented May 19, 2023

Summary

  • Added sa-1b format support

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
@cih9088 cih9088 added data formats PR is related to dataset formats FEATURE New feature & functionality labels May 19, 2023
@cih9088 cih9088 added this to the 1.3.0 milestone May 19, 2023
@cih9088 cih9088 requested review from a team as code owners May 19, 2023 01:51
@cih9088 cih9088 force-pushed the feature/sa-1b-support branch 2 times, most recently from 1ad1e29 to f2059f6 Compare May 19, 2023 01:54
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2023

Codecov Report

Patch coverage: 72.25% and project coverage change: -0.04 ⚠️

Comparison is base (fe351ae) 78.52% compared to head (8c6056e) 78.48%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1005      +/-   ##
===========================================
- Coverage    78.52%   78.48%   -0.04%     
===========================================
  Files          233      237       +4     
  Lines        26757    26973     +216     
  Branches      5323     5369      +46     
===========================================
+ Hits         21012    21171     +159     
- Misses        4496     4532      +36     
- Partials      1249     1270      +21     
Flag Coverage Δ
macos-11_Python-3.8 77.49% <72.25%> (-0.04%) ⬇️
ubuntu-20.04_Python-3.8 ?
windows-2019_Python-3.8 78.37% <72.25%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/util/annotation_util.py 72.78% <0.00%> (-0.94%) ⬇️
...maro/plugins/data_formats/segment_anything/base.py 67.12% <67.12%> (ø)
.../plugins/data_formats/segment_anything/exporter.py 72.94% <72.94%> (ø)
.../plugins/data_formats/segment_anything/importer.py 83.33% <83.33%> (ø)
datumaro/components/format_detection.py 93.68% <100.00%> (+0.10%) ⬆️
.../plugins/data_formats/segment_anything/__init__.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

cih9088 and others added 5 commits May 19, 2023 12:32
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Co-authored-by: Vinnam Kim <vinnam.kim@gmail.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
vinnamkim
vinnamkim previously approved these changes May 19, 2023
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it seems good to add test cases to verify merging annotations in the subsequent PR.

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
@cih9088 cih9088 merged commit 5c3e21a into openvinotoolkit:develop May 22, 2023
@cih9088 cih9088 deleted the feature/sa-1b-support branch May 22, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data formats PR is related to dataset formats FEATURE New feature & functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants