Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder auc only when needed #91

Merged
merged 4 commits into from
Feb 3, 2022
Merged

Reorder auc only when needed #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
501afb6
reorder fpr array when needed
djdameln Jan 28, 2022
bd00a79
add todo for adding stable sort after pytorch upgrade
djdameln Jan 28, 2022
95357e3
mypy
djdameln Feb 2, 2022
9ef16fa
set black version to match precommit
djdameln Feb 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions anomalib/core/metrics/auroc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
"""Implementation of AUROC metric based on TorchMetrics."""
import torch
from torch import Tensor
from torchmetrics import ROC
from torchmetrics.functional import auc
Expand All @@ -13,5 +14,11 @@ def compute(self) -> Tensor:
Returns:
Value of the AUROC metric
"""
tpr: Tensor
fpr: Tensor

fpr, tpr, _thresholds = super().compute()
# TODO: use stable sort after upgrading to pytorch 1.9.x (https://github.com/openvinotoolkit/anomalib/issues/92)
if not (torch.all(fpr.diff() <= 0) or torch.all(fpr.diff() >= 0)):
return auc(fpr, tpr, reorder=True) # only reorder if fpr is not increasing or decreasing
return auc(fpr, tpr)
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ envlist =

[testenv:black]
basepython = python3
deps = black
deps = black==20.8b1
commands = black --check --diff anomalib -l 120

[testenv:isort]
Expand Down