Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace SupportIndex with int #76

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Replace SupportIndex with int #76

merged 1 commit into from
Jan 18, 2022

Conversation

samet-akcay
Copy link
Contributor

@samet-akcay samet-akcay commented Jan 18, 2022 •
edited
Loading

Description

  • This PR replaces SupportIndex with int, which was an artifact from commits from long time ago.

  • Fixes Support python 3.7 #72

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@samet-akcay samet-akcay added the Enhancement New feature or request label Jan 18, 2022
@samet-akcay samet-akcay merged commit 341bddf into development Jan 18, 2022
@samet-akcay samet-akcay deleted the fix/sa/python3.7-support branch January 18, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinvaidya17 ashwinvaidya17 ashwinvaidya17 approved these changes

@djdameln djdameln djdameln approved these changes

Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support python 3.7
3 participants
@samet-akcay @ashwinvaidya17 @djdameln