Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TorchMetrics #7

Merged
merged 21 commits into from
Dec 2, 2021
Merged

TorchMetrics #7

merged 21 commits into from
Dec 2, 2021

Conversation

djdameln
Copy link
Contributor

This PR adds performance evaluation based on TorchMetrics. The ClassificationResults and SegmentationResults classes have been removed, and replaced by MetricCollection objects.

ashwinvaidya17
ashwinvaidya17 reviewed Nov 29, 2021
View reviewed changes
anomalib/core/callbacks/visualizer_callback.py Outdated Show resolved Hide resolved
tests/models/test_model.py Outdated Show resolved Hide resolved
samet-akcay
samet-akcay requested changes Nov 29, 2021
View reviewed changes
anomalib/core/callbacks/visualizer_callback.py Outdated Show resolved Hide resolved
anomalib/core/metrics/opt_f1.py Outdated Show resolved Hide resolved
anomalib/core/metrics/opt_f1.py Outdated Show resolved Hide resolved
anomalib/core/metrics/opt_f1.py Outdated Show resolved Hide resolved
anomalib/core/model/anomaly_module.py Show resolved Hide resolved
anomalib/core/model/anomaly_module.py Show resolved Hide resolved
anomalib/models/patchcore/model.py Outdated Show resolved Hide resolved
ashwinvaidya17
ashwinvaidya17 reviewed Nov 30, 2021
View reviewed changes
tests/models/test_model.py Outdated Show resolved Hide resolved
tests/models/test_model.py Outdated Show resolved Hide resolved
samet-akcay
samet-akcay reviewed Dec 1, 2021
View reviewed changes
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Only minor stuff.

@djdameln
Copy link
Contributor Author

djdameln commented Dec 1, 2021

@samet-akcay I've addressed your comments

samet-akcay
samet-akcay approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @djdameln, looks great!

@samet-akcay samet-akcay merged commit e48835f into development Dec 2, 2021
@samet-akcay samet-akcay deleted the feature/dick/torch-metrics branch December 2, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinvaidya17 ashwinvaidya17 ashwinvaidya17 approved these changes

@samet-akcay samet-akcay samet-akcay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@djdameln @ashwinvaidya17 @samet-akcay