Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reutrn results of load_state_dict func #546

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

zywvvd
Copy link
Contributor

@zywvvd zywvvd commented Sep 8, 2022

you have to reutrn the results of load_state_dict if you wrappered the original one

Description

  • Provide a summary of the modification as well as the issue that has been resolved. List any dependencies that this modification necessitates.

  • Fixes # (issue)

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

you have to reutrn the results of load_state_dict if you wrappered the original one
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for identifying this!

Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

@ashwinvaidya17 do you think this may have introduced any bugs on the OTE side?

@ashwinvaidya17
Copy link
Collaborator

Thanks for spotting this!

@ashwinvaidya17 do you think this may have introduced any bugs on the OTE side?

I don't think so as we load the model outside pytorch lightning trainer. Load state dict returns a tuple with missing keys and unexpected keys. We don't use these value anywhere. It is possible that the lightning trainer may be using it internally for checkpoints but I haven't seen any issues on OTE for now.

@samet-akcay
Copy link
Contributor

Thanks @zywvvd, and welcome to the anomalib contributor community!

@samet-akcay samet-akcay merged commit dff86b1 into openvinotoolkit:main Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants