Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarking tool with Comet #545

Merged
merged 6 commits into from
Sep 14, 2022
Merged

Benchmarking tool with Comet #545

merged 6 commits into from
Sep 14, 2022

Conversation

sherpan
Copy link
Contributor

@sherpan sherpan commented Sep 7, 2022

Description

This PR enables Users to select comet as their writer for the Benchmarking Tool

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@sherpan
Copy link
Contributor Author

sherpan commented Sep 8, 2022

Not sure but both seem to be passing on my end!

pre-commit

tox

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I have one suggestion. Also, do you have a link to the comet project for a sample benchmark run? I'm interested in seeing how it shows up in comet's UI.

tools/benchmarking/benchmark.py Show resolved Hide resolved
tools/benchmarking/utils/metrics.py Show resolved Hide resolved
@sherpan
Copy link
Contributor Author

sherpan commented Sep 9, 2022

Hey @ashwinvaidya17

Here is my comet project for benchmarking!

@ashwinvaidya17 ashwinvaidya17 merged commit e9809c4 into openvinotoolkit:main Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants