Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min-max normalization #53

Merged
merged 15 commits into from
Jan 5, 2022

Conversation

djdameln
Copy link
Contributor

Description

  • Adds min-max normalization as an optional method for normalizing the anomaly scores and heatmaps.
  • New MinMaxNormalizationCallback added
  • Add option to change normalization method from the configurable parameters

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good. Only a few very minor comments.

anomalib/core/callbacks/__init__.py Outdated Show resolved Hide resolved
anomalib/models/padim/config.yaml Outdated Show resolved Hide resolved
anomalib/models/padim/config.yaml Outdated Show resolved Hide resolved
anomalib/core/callbacks/__init__.py Outdated Show resolved Hide resolved
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the effort @djdameln. Such a great improvement! Only minor comments.

anomalib/core/callbacks/normalization.py Outdated Show resolved Hide resolved
anomalib/core/callbacks/min_max_normalization.py Outdated Show resolved Hide resolved
@samet-akcay samet-akcay merged commit b169c4d into development Jan 5, 2022
@samet-akcay samet-akcay deleted the feature/dick/simple-normalization branch January 5, 2022 17:20
@samet-akcay samet-akcay linked an issue Jan 5, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename normalization to cdf
3 participants