Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃敤 Pass pre-trained from config to ModelLightning #529

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

samet-akcay
Copy link
Contributor

Description

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@samet-akcay samet-akcay changed the title Pass pre-trained from config to ModelLightning 馃獩 Pass pre-trained from config to ModelLightning Aug 31, 2022
@samet-akcay samet-akcay changed the title 馃獩 Pass pre-trained from config to ModelLightning 馃敥 Pass pre-trained from config to ModelLightning Aug 31, 2022
@samet-akcay samet-akcay changed the title 馃敥 Pass pre-trained from config to ModelLightning 馃敤 Pass pre-trained from config to ModelLightning Aug 31, 2022
Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having some doubts about adding this parameter. For feature extraction based models such as padim and dfm, what would be the use case of having a non pre-trained backbone? Since the training does not involve finetuning the backbone weights, the normality model would be built upon random layer activations.

@samet-akcay
Copy link
Contributor Author

I'm having some doubts about adding this parameter. For feature extraction based models such as padim and dfm, what would be the use case of having a non pre-trained backbone? Since the training does not involve finetuning the backbone weights, the normality model would be built upon random layer activations.

I don't know if there is a specific use-case for this. config.yaml file contains pre_trained flag. If we dont want this, maybe we could remove this from the config file itself.

Perhaps you could ask this question in PR 514 to confirm whether this actually has any use-case?

Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the discussion in the other PR (#514) I think this is a viable use case, so I'm happy to merge this one.

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@samet-akcay samet-akcay merged commit baca449 into main Sep 9, 2022
@samet-akcay samet-akcay deleted the fix/sa/pass-pre-trained-param-to-class-init branch September 9, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants