Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset adaptive threshold between epochs #527

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

djdameln
Copy link
Contributor

@djdameln djdameln commented Aug 30, 2022

Description

  • Add call to reset method of AdaptiveThreshold metrics. This makes sure that the targets and predictions of previous epochs are cleared before computing the threshold.

  • AdaptiveThreshold class now inherits from PrecisionRecallCurve to prevent having to re-implement update and reset methods.

  • Fixes question about AdaptiveThreshold, possible bug? #457

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@github-actions github-actions bot added the Metrics Metric Component. label Aug 30, 2022
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@samet-akcay samet-akcay merged commit a03e592 into main Aug 31, 2022
@samet-akcay samet-akcay deleted the da/reset-threshold-metrics branch August 31, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Metrics Metric Component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

question about AdaptiveThreshold, possible bug?
3 participants