Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/comet logging #517

Merged
merged 40 commits into from
Sep 2, 2022
Merged

Feature/comet logging #517

merged 40 commits into from
Sep 2, 2022

Conversation

sherpan
Copy link
Contributor

@sherpan sherpan commented Aug 26, 2022

Description

Add comet as a potential logger for the repo

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

Siddharth Mehta and others added 26 commits August 14, 2022 23:40
Co-authored-by:  Boris Feld <lothiraldan@gmail.com>
Co-authored-by:  Boris Feld <lothiraldan@gmail.com>
Co-authored-by:  Boris Feld <lothiraldan@gmail.com>
Co-authored-by:  Boris Feld <lothiraldan@gmail.com>
Co-authored-by:  Boris Feld <lothiraldan@gmail.com>
@github-actions github-actions bot added Callbacks Dependencies Pull requests that update a dependency file Logger labels Aug 26, 2022
@ashwinvaidya17
Copy link
Collaborator

Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sherpan ! I have few minor comments.

docs/source/guides/logging.rst Outdated Show resolved Hide resolved
anomalib/utils/loggers/__init__.py Outdated Show resolved Hide resolved
anomalib/utils/callbacks/graph.py Outdated Show resolved Hide resolved
docs/blog/001-train-custom-dataset/README.md Show resolved Hide resolved
anomalib/utils/loggers/comet.py Outdated Show resolved Hide resolved
@sherpan
Copy link
Contributor Author

sherpan commented Aug 30, 2022

Believe i resolved all of the comments!

@samet-akcay
Copy link
Contributor

@sherpan, I was wondering if you could install pre-commit in your local environment, which would solve all these issues that you are having. Something like

pip install pre-commit
pre-commit run --all-files

This would fix the issues, after which you could push your changes.

@sherpan
Copy link
Contributor Author

sherpan commented Sep 1, 2022

hey samet, yeah i think you are right! will do that next time? Think i am passing everything now?

@sherpan
Copy link
Contributor Author

sherpan commented Sep 1, 2022

confused. here is what i am seeing on my side?
Screen Shot 2022-09-01 at 11 04 26 AM

@samet-akcay
Copy link
Contributor

That's peculiar. No worries, though. We'll sort out the rest. Thanks a lot for the contribution! Much appreciated!

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes

@ashwinvaidya17
Copy link
Collaborator

@sherpan There is probably something wrong with your environment. I am getting the same issues.
image
I have pushed the fix to this branch https://github.com/openvinotoolkit/anomalib/tree/fix/ashwin/linting. I cannot update your branch as I don't have permissions for your fork.

@ashwinvaidya17
Copy link
Collaborator

Or maybe we can merge this branch and I can open a new PR for https://github.com/openvinotoolkit/anomalib/tree/fix/ashwin/linting. @samet-akcay @djdameln ?

@ashwinvaidya17 ashwinvaidya17 merged commit 3ae63a1 into openvinotoolkit:main Sep 2, 2022
@sherpan sherpan deleted the feature/comet_logging branch September 12, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file Logger Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants