Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change hardcoded dataset path to environ variable #51

Merged
merged 2 commits into from
Jan 5, 2022
Merged

Change hardcoded dataset path to environ variable #51

merged 2 commits into from
Jan 5, 2022

Conversation

ashwinvaidya17
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 commented Dec 27, 2021 •
edited
Loading

Changes

  • Use environment variable for dataset path. This will make the tests agnostic to the machine on which it is run on.
  • The workflow file is changed to point to the dataset path on the server.

@ashwinvaidya17 ashwinvaidya17 changed the title Draft: Change hardcoded dataset path to environ variable Change hardcoded dataset path to environ variable Dec 28, 2021
@samet-akcay samet-akcay merged commit 2bae059 into development Jan 5, 2022
@samet-akcay samet-akcay deleted the fix/ashwin/update_test_path branch January 5, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samet-akcay samet-akcay samet-akcay approved these changes

@djdameln djdameln djdameln approved these changes

Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashwinvaidya17 @samet-akcay @djdameln