Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable generic exporting of a trained model to ONNX or OpenVINO IR #509

Merged
merged 15 commits into from
Aug 24, 2022

Conversation

ashishbdatta
Copy link
Contributor

@ashishbdatta ashishbdatta commented Aug 18, 2022

Description

Allowing the user to export a model to either just onnx model or onnx model + openvino IR

API Breakage

This breaks backwards compatibility in the config file where a user used to apply OpenVINO optimization.

It goes from

optimization:
  openvino:
    apply: true

to

optimization:
    export_mode: "onnx/openvino"

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@ashishbdatta ashishbdatta changed the title WIP Enable generic exporting of a trained model Enable generic exporting of a trained model to ONNX or OpenVINO IR Aug 18, 2022
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I have one minor comment

anomalib/utils/callbacks/__init__.py Outdated Show resolved Hide resolved
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! I have few points, other than those, looks great!

anomalib/deploy/optimize.py Outdated Show resolved Hide resolved
anomalib/models/cflow/config.yaml Outdated Show resolved Hide resolved
anomalib/models/dfkde/config.yaml Outdated Show resolved Hide resolved
anomalib/utils/callbacks/__init__.py Show resolved Hide resolved
anomalib/utils/cli/cli.py Outdated Show resolved Hide resolved
tests/pre_merge/deploy/test_inferencer.py Outdated Show resolved Hide resolved
Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a nice addition

Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great addition to the repo!

@samet-akcay samet-akcay merged commit ac55462 into main Aug 24, 2022
@samet-akcay samet-akcay deleted the ad/generic_export branch August 24, 2022 04:33
@samet-akcay samet-akcay linked an issue Sep 9, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for onnx export
4 participants