Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PRO metric #508

Merged
merged 9 commits into from
Aug 31, 2022
Merged

Add PRO metric #508

merged 9 commits into from
Aug 31, 2022

Conversation

djdameln
Copy link
Contributor

Description

This PR adds the PRO metric, and speeds up AUPRO computation when on cpu.

  • Add PRO metric
  • Add alternative connected component computation method to speed up evaluation on CPU.

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not very familiar with this technique so I didn't understand some parts of it but other than that the PR looks good. Thanks!

anomalib/utils/metrics/pro.py Show resolved Hide resolved
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, only 2 minor comments.

anomalib/utils/metrics/pro.py Outdated Show resolved Hide resolved
anomalib/utils/metrics/pro.py Outdated Show resolved Hide resolved
@djdameln
Copy link
Contributor Author

@samet-akcay I didn't realize this PR was still open. I just addressed your comments. Could you do another round of review?

Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good 🔥, thanks

@samet-akcay samet-akcay merged commit bd36919 into main Aug 31, 2022
@samet-akcay samet-akcay deleted the da/add-pro-metric branch August 31, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Metrics Metric Component. Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants