Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Readmes #46

Merged
merged 12 commits into from
Dec 24, 2021
Merged

Fix Readmes #46

merged 12 commits into from
Dec 24, 2021

Conversation

ashwinvaidya17
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 commented Dec 22, 2021

Changes

  • Modify model specific READMEs
  • Add metrics to Main README

Possible Issues

I have explained the models based on my understanding. Might be wrong. It would be nice to look into that first.

@ashwinvaidya17 ashwinvaidya17 added the Enhancement New feature or request label Dec 22, 2021
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
python tools/train.py # Train PADIM on MVTec leather
```

Training a model on a specific dataset and category requires further configuration. Each model has its own configuration
file, [`config.yaml`](https://gitlab-icv.inn.intel.com/algo_rnd_team/anomaly/-/blob/development/stfpm/anomalib/models/stfpm/config.yaml)
, which contains data, model and training configurable parameters. To train a specific model on a specific dataset and
category, the config file is to be provided:
```

```bash
python tools/train.py --model_config_path <path/to/model/config.yaml>
Copy link
Contributor

@samet-akcay samet-akcay Dec 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python tools/train.py --model_config_path anomalib/models/stfpm/config.yaml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To show that we have some sample configs for each algo

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ashwinvaidya17! What an improvement! Only minor stuff on the main readme file. It's based on personal experience. When I first try a repo, I just copy paste the example code to see if it works. If not, I got annoyed easily :D

README.md Outdated Show resolved Hide resolved
@samet-akcay samet-akcay merged commit 5bb4b61 into development Dec 24, 2021
@samet-akcay samet-akcay deleted the refactor/ashwin/fix_readmes branch December 24, 2021 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants