Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Torch Inferencer and Update Openvino and Gradio Inferencers. #453
Add Torch Inferencer and Update Openvino and Gradio Inferencers. #453
Changes from 10 commits
85f5315
062782b
9bd8dba
86375c2
ccd1ad9
2836b34
6df0420
d308dbb
e34f8e3
923bb14
3a670e5
65837c8
ee533e8
a40f297
93ba480
67be9c4
648c3e4
bfa33d7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we warn users if thresholds are not present in meta_data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would bring up another discussion. Do you think we should check if they are in meta_data?
For example,
We cannot calculate the pred-label if we don't have this. The question is whether we should have this if statement here, and for the rest of the computation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the default threshold is 0.5 so if we don't have
image_threshold
in meta_data then we can throw a warning and reduce the if statement topred_label = pred_score >= meta_data.get("image_threshold", 0.5)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as we throw a warning it should be fine. Because the users need to be made aware that there is a problem with the metadata file.