Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃洜 Fix tox configuration #446

Merged
merged 8 commits into from
Jul 27, 2022
Merged

Conversation

samet-akcay
Copy link
Contributor

Description

  • Current pre-commit and tox configuration sometimes cause discrepancies due to using different package versions of black, isort, flake8, pylint, mypy and pydocstyle. This PR addresses this issue by removing the individual checks from tox and running pre-commit run --all-files from tox itself.

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for simplifying this. I have one comment.

requirements/dev.txt Outdated Show resolved Hide resolved
@samet-akcay samet-akcay merged commit 150ff7a into development Jul 27, 2022
@samet-akcay samet-akcay deleted the fix/sa/tox-configuration branch July 27, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants