Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/aupro test #444

Merged
merged 5 commits into from
Jul 20, 2022
Merged

Feature/aupro test #444

merged 5 commits into from
Jul 20, 2022

Conversation

ORippler
Copy link
Contributor

@ORippler ORippler commented Jul 18, 2022

Description

  • Provide a summary of the modification as well as the issue that has been resolved. List any dependencies that this modification necessitates.

    • Adds unit-tests for AUPRO metric. While writing the tests, edge-cases were discovered and smaller bugs fixed.
  • Fixes Add unit-tests for AUPRO metric #443

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

Remarks:

The reference implementation is taken from here, and currently unlicensed. The code itself is an adaptation of the official reference-code provided by MVTec.

If this prevents merging the PR, I would suggest removing the code and the corresponding tests from the unit-tests.

Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ORippler for adding this!

The test scripts do not seem to follow the code-quality standards, but it's ok for now. We don't check the tests at the moment, which we need to refactor quite soon.

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this PR! I have a single concern regarding the license.

tests/helpers/aupro_reference.py Show resolved Hide resolved
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@samet-akcay samet-akcay merged commit a946140 into openvinotoolkit:development Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit-tests for AUPRO metric
3 participants