Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃搩 Add documentation for gradio inference #427

Merged
merged 2 commits into from
Jul 11, 2022

Conversation

ashwinvaidya17
Copy link
Collaborator

Description

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@samet-akcay
Copy link
Contributor

Have you checked whether Gradio works fine? When I checked it on Friday, it was partially working.

@ashwinvaidya17
Copy link
Collaborator Author

Have you checked whether Gradio works fine? When I checked it on Friday, it was partially working.

Yeah openvino was not working but I've changed that line in the file. I've tested both the examples on my windows machine.

Comment on lines +91 to +93
python tools/inference/gradio_inference.py \
--config ./anomalib/models/padim/config.yaml \
--weights ./results/padim/mvtec/bottle/weights/model.ckpt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe another PR, but I think we should use the lightning inference to handle the meta-data automatically. Otherwise, we manually need to tune the threshold on the UI

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this requires refactor but we should load the initial value of threshold from the model/metadata json file. With that as the default value, the users can then play around with the threshold.

@samet-akcay samet-akcay merged commit b094410 into development Jul 11, 2022
@samet-akcay samet-akcay deleted the ashwin/gradio_documentation branch July 11, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Gradio Documentation
2 participants