Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the redundant loss_val #425

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Remove the redundant loss_val #425

merged 1 commit into from
Jul 11, 2022

Conversation

samet-akcay
Copy link
Contributor

Description

  • Currently the loss in STFPM is computed as follows : loss = self.loss_val + self.loss(teacher_features, student_features). However, self.loss_val is always zero and adds no value. This PR therefore removes it from the computation.

  • Fixes STFPM loss #421

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@samet-akcay samet-akcay merged commit 00492cf into development Jul 11, 2022
@samet-akcay samet-akcay deleted the fix/sa/stfpm-loss branch July 11, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STFPM loss
2 participants