Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚚 Move perlin noise to common folder #424

Merged
merged 7 commits into from
Jul 15, 2022
Merged

🚚 Move perlin noise to common folder #424

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
57820d4
Move perlin noise to common folder
ashwinvaidya17 Jul 11, 2022
a93bf03
Fix linting issues
ashwinvaidya17 Jul 11, 2022
c969c63
Move file to data/utils + rename function
ashwinvaidya17 Jul 11, 2022
aca4d9e
Fix function names
ashwinvaidya17 Jul 11, 2022
394468e
Fix mypy issue
ashwinvaidya17 Jul 12, 2022
833b9e6
black
ashwinvaidya17 Jul 12, 2022
220dec3
fix type
Jul 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion anomalib/models/draem/utils/augmenter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
from torch import Tensor
from torchvision.datasets.folder import IMG_EXTENSIONS

from anomalib.models.draem.utils.perlin import rand_perlin_2d_np
from anomalib.utils.generators import rand_perlin_2d_np
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also have anomalib.data.utils directory? Would it be an idea to move this there ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. That's a good idea.



class Augmenter:
Expand Down
8 changes: 8 additions & 0 deletions anomalib/utils/generators/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
"""Utilities to generate synthetic data."""

# Copyright (C) 2022 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

from .perlin import rand_perlin_2d_np
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe for another PR, but would be nice to rename the function as well.


__all__ = ["rand_perlin_2d_np"]
0 anomalib/models/draem/utils/perlin.py → anomalib/utils/generators/perlin.py
View file
Open in desktop
File renamed without changes.