Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃洜 Fix configs to remove logging heatmaps from classification models. #387

Merged

Conversation

samet-akcay
Copy link
Contributor

Description

  • Currently classification models has log_images_to: ["local"] option in the config files. This is a bug since the classification models do not produce anomaly maps to log. This PR fixes this by changing this configuration to log_images_to: [].

  • Fixes KeyError: 'anomaly_maps'聽#371

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@samet-akcay samet-akcay added Bug Something isn't working Model labels Jun 27, 2022
@samet-akcay samet-akcay merged commit 85484ff into development Jun 27, 2022
@samet-akcay samet-akcay deleted the fix/sa/disable-anomaly-maps-for-classification-models branch June 27, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError: 'anomaly_maps'
2 participants