Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #382

Merged
merged 3 commits into from
Jun 22, 2022
Merged

Conversation

innat
Copy link
Contributor

@innat innat commented Jun 21, 2022

Description

  • Add colab and kaggle badges.

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

README.md Outdated Show resolved Hide resolved
@ashwinvaidya17
Copy link
Collaborator

Not in the scope of this PR but it would be nice if you (@innat and @bth5) fix the anomalib version/commit in your notebooks to ensure that they work in the future as well 😃

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments but I am fine if we merge with current change.

@innat
Copy link
Contributor Author

innat commented Jun 21, 2022

Not in the scope of this PR but it would be nice if you (@innat and @bth5) fix the anomalib version/commit in your notebooks to ensure that they work in the future as well 😃

I updated the kaggle version with the current commit. But I think it would be great if anyone from the anomalib team were willing to collaborate. In kaggle notebook, I can add him as a collaborator in kaggle notebook.

@ashwinvaidya17 ashwinvaidya17 merged commit 93bfe84 into openvinotoolkit:development Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants