Create Anomalib CLI #378
Create Anomalib CLI #378
Conversation
…o nb/sa/add-dataset-module-notebook
…notoolkit/anomalib into nb/sa/add-dataset-module-notebook
…o nb/sa/add-dataset-module-notebook
…o samet-akcay/issue21
samet-akcay
requested review from
ashwinvaidya17 and
djdameln
and removed request for
ashwinvaidya17
|
Can you add commands to run the models to the README? |
|
| model_name = config.model.class_path.split(".")[-1].lower() | ||
| data_name = config.data.class_path.split(".")[-1].lower() | ||
| category = config.data.init_args.category if config.data.init_args.keys() else "" | ||
| time_stamp = datetime.now().strftime("%Y-%m-%d_%H-%M-%S") |
There was a problem hiding this comment.
What do you think about this time_stamp here?
There was a problem hiding this comment.
I don't see an issue with it.
| parser.set_defaults( | ||
| { | ||
| "metrics.adaptive_threshold": True, | ||
| "metrics.default_image_threshold": None, | ||
| "metrics.default_pixel_threshold": None, | ||
| "metrics.image_metric_names": ["F1Score", "AUROC"], | ||
| "metrics.pixel_metric_names": ["F1Score", "AUROC"], | ||
| "metrics.normalization_method": "min_max", | ||
| } | ||
| ) |
There was a problem hiding this comment.
I'm probably misunderstanding something, but why do we need to set the defaults? Aren't those parsed from the config?
There was a problem hiding this comment.
If they are provided in the config, yes, they are parsed from the config file. However, if the user does not provide those parameters from the config file, then this part sets these by default. With this approach it becomes also possible to configure these from the CLI as well.
anomalib/utils/cli/cli.py
Outdated
| } | ||
| ) | ||
|
|
||
| def before_instantiate_classes(self) -> None: |
There was a problem hiding this comment.
This method is quite long and therefore a bit hard to navigate. Do you think you could split it between several smaller methods?
| # TODO: This is a workaround. normalization-method is actually not used in metrics. | ||
| # It's only accessed from `before_instantiate` method in `AnomalibCLI` to configure | ||
| # its callback. | ||
| self.normalization_method = normalization_method |
There was a problem hiding this comment.
Not sure I understand this. Maybe we could discuss it in the daily
Description
This is to add new anomalib cli that is based on pytorch lightning cli. With this design it'll be possible to tweak the parameters from both config files and cli simultaneously.
Fixes Refactor Anomalib CLI #21
Changes
Checklist