Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix too many open images warning #334

Merged
merged 1 commit into from
May 30, 2022
Merged

Conversation

djdameln
Copy link
Contributor

Description

This PR fixes a bug that caused too many matplotlib figures to be retained in memory. visualizer.generate() was unintentionally called twice for every image, causing the number of open images to build up as the test loop progressed. Fixed by leaving the responsibility of calling visualizer.generate() to the callback class instead of the visualizer itself.

Note: Since this bug affected development, I target development in this PR. Will rebase the feature branch to pull in the changes there.

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this

@djdameln djdameln merged commit 10db405 into development May 30, 2022
@djdameln djdameln deleted the da/fix-too-many-open-images branch May 30, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants