Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add input_info to nncf config when not defined by user #307

Merged
merged 1 commit into from
May 12, 2022

Conversation

djdameln
Copy link
Contributor

Description

  • Adds input_info to the NNCF config when this has not been defined by the user in the config.yaml.

This allows users to enable NNCF by adding the following to config.yaml:

optimization:
    nncf:
        apply: true

Where previously, the following was needed:

optimization:
    nncf:
        apply: true
        input_info:
            sample_size: null

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@samet-akcay
Copy link
Contributor

Do you think if we should add the nncf settings to the config files as well? Currently, none of the config files have nncf

@samet-akcay samet-akcay merged commit 9b117b0 into development May 12, 2022
@samet-akcay samet-akcay deleted the da/add-default-nncf-config branch May 12, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants