Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧪 Add tests for benchmarking script #297

Merged
merged 9 commits into from
May 12, 2022
Merged

🧪 Add tests for benchmarking script #297

merged 9 commits into from
May 12, 2022

Conversation

ashwinvaidya17
Copy link
Collaborator

Description

  • Adds test to benchmarking script. Increases the test time by ~3mins. Should I move this to nightly?

Changes

  • Add test for benchmarking script

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

samet-akcay
samet-akcay reviewed May 5, 2022
View reviewed changes
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would agree that benchmarking could go to the nightly tests.

samet-akcay
samet-akcay reviewed May 5, 2022
View reviewed changes
tests/pre_merge/tools/benchmarking/test_benchmarking.py Outdated
from tests.helpers.dataset import get_dataset_path


def check_tf_logs(model: str):
Copy link
Contributor

@samet-akcay samet-akcay May 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does tf refer to? If tensorboard, should this be check_tb_logs?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap! My bad

@ashwinvaidya17
Copy link
Collaborator Author

I would agree that benchmarking could go to the nightly tests.

I'll move it to nightly once CI passes

@samet-akcay samet-akcay merged commit 995aa8c into development May 12, 2022
@samet-akcay samet-akcay deleted the tests/av/benchmarking branch May 12, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samet-akcay samet-akcay samet-akcay approved these changes

@djdameln djdameln Awaiting requested review from djdameln

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashwinvaidya17 @samet-akcay