Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualizer improvements pt1 #293

Merged
merged 8 commits into from
May 5, 2022

Conversation

djdameln
Copy link
Contributor

@djdameln djdameln commented May 3, 2022

Description

First part of the visualizer refactor. Improves the looks of the images, especially for classification.
Example image for classification:
000_cls
Example image for segmentation:
000_seg

Also improves the logic within the visualizer callback class.

Fixes

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@djdameln djdameln requested review from samet-akcay and ashwinvaidya17 and removed request for samet-akcay May 3, 2022 10:30
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The output looks much better now.


self.figure, self.axis = plt.subplots(num_rows, num_cols, figsize=figure_size)
self.figure.subplots_adjust(right=0.9)
self.images = []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add annotation to self.images

@@ -3,7 +3,7 @@ dataset:
format: mvtec
path: ./datasets/MVTec
category: bottle
task: segmentation
task: classification
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was committed unintentionally. I'll revert it

@samet-akcay samet-akcay merged commit 6e518ac into development May 5, 2022
@samet-akcay samet-akcay deleted the da/visualizer-classification-labels branch May 5, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants