Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃敡 Properly assign values to dataframe in folder dataset. #272

Merged

Conversation

samet-akcay
Copy link
Contributor

@samet-akcay samet-akcay commented Apr 25, 2022

Description

  • Currently folder dataset directly assigns values to dataframe without using .loc, which causes the following warning:
SettingWithCopyWarning:
A value is trying to be set on a copy of a slice from a DataFrame

See the caveats in the documentation: https://pandas.pydata.org/pandas-docs/stable/user_guide/indexing.html#returning-a-view-versus-a-copy
  • This PR fixes this by properly assigning values to dataframe rows.

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@samet-akcay samet-akcay self-assigned this Apr 25, 2022
@samet-akcay samet-akcay added Enhancement New feature or request Data labels Apr 25, 2022
@samet-akcay samet-akcay merged commit d0fb1f8 into development Apr 25, 2022
@samet-akcay samet-akcay deleted the fix/sa/dataframe-indexing-in-folder-dataset branch April 25, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants