Add segmentation mask to inference output #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feature/av/inferencer_heatmap
samet-akcay
reviewed
Apr 21, 2022
tools/inference.py
Outdated
| @@ -124,7 +124,7 @@ def infer(image_path: Path, inferencer: Inferencer, save_path: Optional[Path] = | |||
| # path is provided, `predict` method will read the image from | |||
| # file for convenience. We set the superimpose flag to True | |||
| # to overlay the predicted anomaly map on top of the input image. | |||
| output = inferencer.predict(image=image_path, superimpose=True) | |||
| output = inferencer.predict(image=image_path, superimpose=True, overlay_mask=True) | |||
There was a problem hiding this comment.
Do you think if overlay_mask should always be True or optional?
djdameln
requested changes
Apr 21, 2022
|
Done! |
|
This looks good! I'm not sure if it's only me but I do hate opencv fonts, which looks archaic! Of course, this is for another PR, but I feel like it would be nice if we have a polished output image with a moderner font. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note
I haven't tested this with OpenVINO as the installation is broken on my windows machine.
Changes
Checklist