Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address compatibility issues with OTE, that are caused by the legacy code. #24

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Address compatibility issues with OTE, that are caused by the legacy code. #24

merged 1 commit into from
Dec 14, 2021

Conversation

samet-akcay
Copy link
Contributor

Changes

This PR fixes the compatibility issues with OTE SDK. After tagging this version as v0.1.2+, GitHub should be fully compatible

@samet-akcay samet-akcay added the Enhancement New feature or request label Dec 13, 2021
ashwinvaidya17
ashwinvaidya17 approved these changes Dec 13, 2021
View reviewed changes
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The config stuff in preprocessor addresses an issue I had in benchmarking script. Maybe we should create a ticket to add inferencer tests.

@djdameln
Copy link
Contributor

Did you test this in SC yet?

@samet-akcay
Copy link
Contributor Author

Did you test this in SC yet?

Tests on OTE Anomalib passes, but gives a warning message. I've shared the log on teams

@samet-akcay
Copy link
Contributor Author

Nice! The config stuff in preprocessor addresses an issue I had in benchmarking script. Maybe we should create a ticket to add inferencer tests.

@ashwinvaidya17 , I agree, we should definitely have inference tests.

@samet-akcay samet-akcay added this to To do in Feature Requests Dec 14, 2021
@samet-akcay samet-akcay merged commit e0345ee into development Dec 14, 2021
Feature Requests automation moved this from To do to Done Dec 14, 2021
@samet-akcay samet-akcay deleted the fix/sa/add-validation-set-split-option-to-mvtec branch December 14, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinvaidya17 ashwinvaidya17 ashwinvaidya17 approved these changes

@djdameln djdameln Awaiting requested review from djdameln

Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
No open projects
Feature Requests
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samet-akcay @djdameln @ashwinvaidya17