Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pimo tutorial advanced i (fixed) #2336

Merged

Conversation

jpcbertoldo
Copy link
Contributor

@jpcbertoldo jpcbertoldo commented Oct 2, 2024

πŸ“ Description

How to select representative samples with AUPIMO scores and how to visualize AUPIMO's bounds on heatmaps.

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • πŸ”¨ Refactor (non-breaking change which refactors the code base)
  • πŸš€ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ“š Documentation update
  • πŸ”’ Security update

βœ… Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • πŸ“‹ I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • πŸ“š I have made the necessary updates to the documentation (if applicable).
  • πŸ§ͺ I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

Signed-off-by: jpcbertoldo <24547377+jpcbertoldo@users.noreply.github.com>
Signed-off-by: jpcbertoldo <24547377+jpcbertoldo@users.noreply.github.com>
Signed-off-by: jpcbertoldo <24547377+jpcbertoldo@users.noreply.github.com>
Copy link

Check out this pull request onΒ  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jpcbertoldo
Copy link
Contributor Author

So i had to remove the outputs of the cells that print images because the notebook would be too big (8mb), and the 500kb size limit blocked my commit.

It's kinda shame not to have those images there cause it's like half of the notebook's message.

Is there a trick to work around this?
Or is it ok to do something dirty like save to jpg and reload with an IPython display function, for example ?

Signed-off-by: jpcbertoldo <24547377+jpcbertoldo@users.noreply.github.com>
Signed-off-by: jpcbertoldo <24547377+jpcbertoldo@users.noreply.github.com>
Signed-off-by: jpcbertoldo <24547377+jpcbertoldo@users.noreply.github.com>
@jpcbertoldo
Copy link
Contributor Author

So i had to remove the outputs of the cells that print images because the notebook would be too big (8mb), and the 500kb size limit blocked my commit.

Update: reducing the images to 96x96 (instead of 256x256) makes the file have 1.8mb. Still above the limit but would that be ok?

Signed-off-by: jpcbertoldo <24547377+jpcbertoldo@users.noreply.github.com>
@jpcbertoldo
Copy link
Contributor Author

jpcbertoldo commented Oct 4, 2024

@ashwinvaidya17 could you check this one if you have some time? : )

it's teaching and documenting one of those use cases that disappeared in the refactor

Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@jpcbertoldo
Copy link
Contributor Author

lgtm, thanks

do you have a suggestion about including the images in the notebook?
would it be ok to commit a big file (<10mb) if it's in anomalib/notebooks?

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 80.77%. Comparing base (404e896) to head (8bbb1be).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2336   +/-   ##
=======================================
  Coverage   80.77%   80.77%           
=======================================
  Files         254      254           
  Lines       11463    11463           
=======================================
  Hits         9259     9259           
  Misses       2204     2204           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@jpcbertoldo jpcbertoldo mentioned this pull request Oct 4, 2024
9 tasks
@samet-akcay samet-akcay enabled auto-merge (squash) October 6, 2024 06:39
@samet-akcay samet-akcay merged commit 2ba5ede into openvinotoolkit:main Oct 6, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants