-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pimo tutorial advanced i (fixed) #2336
Add pimo tutorial advanced i (fixed) #2336
Conversation
Signed-off-by: jpcbertoldo <24547377+jpcbertoldo@users.noreply.github.com>
Signed-off-by: jpcbertoldo <24547377+jpcbertoldo@users.noreply.github.com>
Signed-off-by: jpcbertoldo <24547377+jpcbertoldo@users.noreply.github.com>
Check out this pull request onΒ See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
So i had to remove the outputs of the cells that print images because the notebook would be too big (8mb), and the 500kb size limit blocked my commit. It's kinda shame not to have those images there cause it's like half of the notebook's message. Is there a trick to work around this? |
Signed-off-by: jpcbertoldo <24547377+jpcbertoldo@users.noreply.github.com>
Signed-off-by: jpcbertoldo <24547377+jpcbertoldo@users.noreply.github.com>
Signed-off-by: jpcbertoldo <24547377+jpcbertoldo@users.noreply.github.com>
Update: reducing the images to 96x96 (instead of 256x256) makes the file have 1.8mb. Still above the limit but would that be ok? |
Signed-off-by: jpcbertoldo <24547377+jpcbertoldo@users.noreply.github.com>
@ashwinvaidya17 could you check this one if you have some time? : ) it's teaching and documenting one of those use cases that disappeared in the refactor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
do you have a suggestion about including the images in the notebook? |
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #2336 +/- ##
=======================================
Coverage 80.77% 80.77%
=======================================
Files 254 254
Lines 11463 11463
=======================================
Hits 9259 9259
Misses 2204 2204 β View full report in Codecov by Sentry. |
π Description
How to select representative samples with AUPIMO scores and how to visualize AUPIMO's bounds on heatmaps.
β¨ Changes
Select what type of change your PR is:
β Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.