Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent benchmarking throughput/time #221

Merged
merged 4 commits into from
Apr 12, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions tools/benchmarking/benchmark.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,14 @@
# and limitations under the License.


import functools
import io
import logging
import math
import multiprocessing
import sys
import time
import warnings
from concurrent.futures import ProcessPoolExecutor, as_completed
from pathlib import Path
from tempfile import TemporaryDirectory
Expand All @@ -41,9 +45,42 @@
set_in_nested_config,
)

warnings.filterwarnings("ignore")

logger = logging.getLogger(__file__)
logging.getLogger("pytorch_lightning").setLevel(logging.ERROR)
logging.getLogger("torchmetrics").setLevel(logging.ERROR)
logging.getLogger("os").setLevel(logging.ERROR)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could set the level in a for loop to avoid the duplicated lines



def hide_output(func):
"""Decorator to hide output of the function.

Args:
func (function): Hides output of this function.

Raises:
Exception: Incase the execution of function fails, it raises an exception.

Returns:
object of the called function
"""

@functools.wraps(func)
def wrapper(*args, **kwargs):
std_out = sys.stdout
sys.stdout = buf = io.StringIO()
try:
value = func(*args, **kwargs)
except Exception as exp:
raise Exception(buf.getvalue()) from exp
sys.stdout = std_out
return value

return wrapper


@hide_output
def get_single_model_metrics(model_config: Union[DictConfig, ListConfig], openvino_metrics: bool = False) -> Dict:
"""Collects metrics for `model_name` and returns a dict of results.

Expand All @@ -65,6 +102,7 @@ def get_single_model_metrics(model_config: Union[DictConfig, ListConfig], openvi
trainer = Trainer(**model_config.trainer, logger=None, callbacks=callbacks)

start_time = time.time()

trainer.fit(model=model, datamodule=datamodule)

# get start time
Expand Down Expand Up @@ -218,6 +256,8 @@ def sweep(run_config: Union[DictConfig, ListConfig], device: int = 0, seed: int

# Run benchmarking for current config
model_metrics = get_single_model_metrics(model_config=model_config, openvino_metrics=convert_openvino)
print(model_config.model.name, model_config.dataset.category)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we want to run benchmark.py for custom datasets that don't have category field?

print(model_metrics)

# Append configuration of current run to the collected metrics
for key, value in run_config.items():
Expand Down