Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated documentation for development on Docker #217

Merged
merged 4 commits into from
Apr 11, 2022
Merged

Updated documentation for development on Docker #217

merged 4 commits into from
Apr 11, 2022

Conversation

LukasBommes
Copy link
Contributor

Description

Updates the Developing on Docker guide following the enhancements of the Dockerfile as per #172.

Since VSCode is not a necessity for building and running the Docker container, I removed all details regarding the use of VSCode from the docs.

@LukasBommes LukasBommes changed the title Updated Docker Updated documentation for development on Docker Apr 11, 2022
@samet-akcay samet-akcay added Docker Dev Enhancement New feature or request labels Apr 11, 2022
ashwinvaidya17
ashwinvaidya17 reviewed Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this doc with a more thorough guide. However, I still feel we should have a section for those who want to use VS code remote container. We can just keep the section below.

@LukasBommes
Copy link
Contributor Author

Sure. I added the description on VSCode back into a subsection.

ashwinvaidya17
ashwinvaidya17 approved these changes Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

samet-akcay
samet-akcay approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LukasBommes!

@samet-akcay samet-akcay merged commit 54d750d into openvinotoolkit:development Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinvaidya17 ashwinvaidya17 ashwinvaidya17 approved these changes

@samet-akcay samet-akcay samet-akcay approved these changes

Assignees
No one assigned
Labels
Docker Dev Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LukasBommes @ashwinvaidya17 @samet-akcay