Allow specifying feature layer and pool factor in DFM #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djdameln
reviewed
Apr 11, 2022
anomalib/models/dfm/config.yaml
Outdated
| @@ -14,6 +14,8 @@ dataset: | |||
| model: | |||
| name: dfm | |||
| backbone: resnet18 | |||
| layer: layer3 | |||
| pool: 4 | |||
There was a problem hiding this comment.
Maybe this could be renamed to pool_factor to make the parameter a bit more self explanatory
ashwinvaidya17
approved these changes
Apr 11, 2022
djdameln
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two additional parameters need to be specified for DFM: name of the layer from which features are extracted, and an integer pool factor. The features will be average-pooled by the specified pool factor before DFM is applied.
Fixes # (issue)
Changes
Checklist