Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Directory streaming #210

Merged
merged 1 commit into from
Apr 11, 2022
Merged

✨ Directory streaming #210

merged 1 commit into from
Apr 11, 2022

Conversation

ashwinvaidya17
Copy link
Collaborator

Description

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@ashwinvaidya17 ashwinvaidya17 added the Enhancement New feature or request label Apr 8, 2022
djdameln
djdameln approved these changes Apr 11, 2022
View reviewed changes
tools/inference.py
@@ -108,11 +134,17 @@ def infer() -> None:
# Show or save the output image, depending on what's provided as
# the command line argument.
output = cv2.cvtColor(output, cv2.COLOR_RGB2BGR)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should also show the segmentation predictions here, but I guess we could address it separately

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't understand this. Aren't we overlaying anomaly masks on line 127?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I get when I run the inferencer. It just shows the heatmap and the confidence score, no segmentation predictions.
Screenshot from 2022-04-11 12-37-36

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see what you mean. I'll create a ticket for this

@ashwinvaidya17 ashwinvaidya17 merged commit 2405892 into development Apr 11, 2022
@ashwinvaidya17 ashwinvaidya17 deleted the feature/av/directory_inference branch April 11, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djdameln djdameln djdameln approved these changes

@samet-akcay samet-akcay samet-akcay approved these changes

Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inference on a directory of images
3 participants
@ashwinvaidya17 @samet-akcay @djdameln