Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pkg_resources imports and use packaging instead #2082

Merged
merged 4 commits into from
Jul 5, 2024

Conversation

davnn
Copy link
Contributor

@davnn davnn commented May 23, 2024

📝 Description

The pkg_resources module is deprecated and does not export the required symbols in newer versions. It is advised to use packaging or importlib instead. Because we only rely on functionality present in packaging, the change from pkg_resources to packaging should be straightforward.

✨ Changes

Select what type of change your PR is:

  • [ x ] 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • [ x ] 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • [ - ] 📚 I have made the necessary updates to the documentation (if applicable).
  • [ - ] 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davnn ! Can you have a look at the pre-commit checks so we can merge this?

@davnn
Copy link
Contributor Author

davnn commented May 29, 2024

Should be fixed, please merge.

@ashwinvaidya17 ashwinvaidya17 enabled auto-merge (squash) May 29, 2024 16:27
@samet-akcay
Copy link
Contributor

Our CI is currently down. Once fixed, we'll prioritise this PR

@samet-akcay samet-akcay changed the base branch from main to fix/packaging July 5, 2024 12:47
@samet-akcay samet-akcay disabled auto-merge July 5, 2024 12:49
@samet-akcay samet-akcay merged commit 6d22921 into openvinotoolkit:fix/packaging Jul 5, 2024
1 of 4 checks passed
samet-akcay added a commit to samet-akcay/anomalib that referenced this pull request Jul 5, 2024
…it#2082)

remove pkg_resources imports and use packaging instead

Co-authored-by: Samet Akcay <samet.akcay@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants