-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pkg_resources imports and use packaging instead #2082
Remove pkg_resources imports and use packaging instead #2082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @davnn ! Can you have a look at the pre-commit checks so we can merge this?
Should be fixed, please merge. |
Our CI is currently down. Once fixed, we'll prioritise this PR |
6d22921
into
openvinotoolkit:fix/packaging
…it#2082) remove pkg_resources imports and use packaging instead Co-authored-by: Samet Akcay <samet.akcay@intel.com>
📝 Description
The
pkg_resources
module is deprecated and does not export the required symbols in newer versions. It is advised to usepackaging
orimportlib
instead. Because we only rely on functionality present inpackaging
, the change frompkg_resources
topackaging
should be straightforward.✨ Changes
Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.