Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃攧 CFlow: Switch soft permutation to false by default to speed up training. #201

Merged

Conversation

samet-akcay
Copy link
Contributor

@samet-akcay samet-akcay commented Apr 6, 2022

Description

  • This PR switches soft permutation to false by default to speed up training.

  • Add this as a configurable parameter so the user could choose.

  • Fixes e聽#89

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@samet-akcay samet-akcay added Enhancement New feature or request Model labels Apr 6, 2022
@samet-akcay samet-akcay merged commit 97734af into development Apr 6, 2022
@samet-akcay samet-akcay deleted the fix/sa/cflow-switch-to-hard-permutation-by-default branch April 6, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e
2 participants