Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Add MVTec LOCO dataset and sPRO metric #1967

Open
wants to merge 72 commits into
base: main
Choose a base branch
from
Open

Conversation

djdameln
Copy link
Contributor

@djdameln djdameln commented Apr 9, 2024

📝 Description

This PR is based on the closed PR #1686 , which adds the implementation of MVTec LOCO AD dataset [Paper] along with the sPRO metric.

🛠️ Fixes #574 #471 #1341

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

willyfh and others added 30 commits February 9, 2024 12:46
…ectory

Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
…'masks' item

Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
…g from the dataset

Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
…cCollection

Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
…to None

Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
Co-authored-by: Samet Akcay <samet.akcay@intel.com>
Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
Co-authored-by: Samet Akcay <samet.akcay@intel.com>
Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
djdameln and others added 13 commits April 9, 2024 14:13
Co-authored-by: Samet Akcay <samet.akcay@intel.com>
Co-authored-by: Samet Akcay <samet.akcay@intel.com>
Co-authored-by: Samet Akcay <samet.akcay@intel.com>
Co-authored-by: Samet Akcay <samet.akcay@intel.com>
Co-authored-by: Ashwin Vaidya <ashwin.vaidya@intel.com>
Co-authored-by: Samet Akcay <samet.akcay@intel.com>
Co-authored-by: Samet Akcay <samet.akcay@intel.com>
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 81.39%. Comparing base (14ab566) to head (1cc19d7).

Files Patch % Lines
src/anomalib/callbacks/metrics.py 68.75% 10 Missing ⚠️
src/anomalib/metrics/spro.py 85.71% 9 Missing ⚠️
src/anomalib/data/image/mvtec_loco.py 91.57% 8 Missing ⚠️
src/anomalib/data/base/datamodule.py 66.66% 2 Missing ⚠️
src/anomalib/metrics/collection.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1967      +/-   ##
==========================================
+ Coverage   81.32%   81.39%   +0.07%     
==========================================
  Files         229      231       +2     
  Lines       10348    10541     +193     
==========================================
+ Hits         8415     8580     +165     
- Misses       1933     1961      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djdameln djdameln requested a review from samet-akcay May 3, 2024 06:02
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for polishing this. I have one comment.

src/anomalib/data/base/datamodule.py Show resolved Hide resolved
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants